Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re add len check before copying SNI #31

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Re add len check before copying SNI #31

merged 1 commit into from
Oct 27, 2023

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Oct 26, 2023

Task/Issue URL: https://app.asana.com/0/1202552961248957/1205811169823599/f

Description

see asana

Steps to test this PR

  • from this branch, publish the library to maven local ie. ./gradlew clean assemble publishToMavenLocal
  • In the DDG android app apply the following path
Subject: [PATCH] Maven local use
---
Index: build.gradle
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build.gradle b/build.gradle
--- a/build.gradle	(revision d11f7491d7ab4b27223fd352f83c26be403e79ed)
+++ b/build.gradle	(revision 3b1fe446b5d33e4d8a7f400137134ea0b5a797d7)
@@ -40,6 +40,7 @@
     repositories {
         google()
         mavenCentral()
+        mavenLocal()
     }
     configurations.all {
         resolutionStrategy.force 'org.objenesis:objenesis:2.6'
Index: versions.properties
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>ISO-8859-1
===================================================================
diff --git a/versions.properties b/versions.properties
--- a/versions.properties	(revision d11f7491d7ab4b27223fd352f83c26be403e79ed)
+++ b/versions.properties	(revision 3b1fe446b5d33e4d8a7f400137134ea0b5a797d7)
@@ -55,7 +55,7 @@
 
 version.com.android.installreferrer..installreferrer=2.2
 
-version.com.duckduckgo.netguard..netguard-android=1.6.0
+version.com.duckduckgo.netguard..netguard-android=1.7.0-SNAPSHOT
 
 version.com.duckduckgo.synccrypto..sync-crypto-android=0.3.0
  • build DDG app
  • AppTP smoke tests

@aitorvs
Copy link
Collaborator Author

aitorvs commented Oct 26, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@aitorvs aitorvs force-pushed the feature/aitor/add_len_check branch 7 times, most recently from c8ff35e to bee641b Compare October 26, 2023 22:59
joshliebe
joshliebe reviewed Oct 27, 2023
View reviewed changes
src/test/test_tls.c
assert(strcmp("localhost", sn) != 0);
assert(strlen(sn) == 0);
assert(error == -12);
assert(strcmp("lodalhost", sn) == 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(strcmp("lodalhost", sn) == 0);
assert(strcmp("localhost", sn) == 0);

joshliebe
joshliebe approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one typo

@aitorvs aitorvs merged commit 9112c3b into main Oct 27, 2023
1 check passed
@aitorvs aitorvs deleted the feature/aitor/add_len_check branch October 27, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshliebe joshliebe joshliebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitorvs @joshliebe